Shouldn't c++ preprocessor #elif's textmate scope be keyword.control.directive.conditional.elif?

[alexr00]

From @REYNEP in microsoft/vscode#114297

Checklist

• This problem exists even with the setting "C_Cpp.enhancedColorization": "Disabled"
• This bug exists for C
• This bug exists for C++
• This bug exists for Objective-C
• This bug exists for Objective-C++

The code with a problem is:

#elif

It looks like:

#if

It should look like:

WHY?:-

1. all conditional Preprocessor Commands, #if, #else, #endif, #ifdef, #ifndef are inside keyword.control.directive.conditional (eg. keyword.control.directive.conditional.ifdef)
2. But #elif is inside keyword.control.directive, (like this: keyword.control.directive.elif)
3. Shouldn't #elif's textmate scope be under keyword.control.directive.conditional too like the others?

I have fixed this by modifying cpp.tmLanguage.json
At Line 12683 if you add elif beside the other #if #ifdef #ifndef preprocessor commands, this gets fixed

[per1234]

I believe I am experiencing this bug, but found the report to be insufficient. I'll add the missing information:

The code with a problem is:

#if FOO  // Coloration of expression is as expected
#elif BAZ  // Coloration of expression is NOT as expected
#endif

It looks like:

Using "Dark+" theme:

It should look like:

---

I believe the incorrect code is now located here:

better-cpp-syntax/syntaxes/cpp.tmLanguage.json

Line 12806 in 8d51203

"begin": "^((?:(?:(?:(?>(?:\\s)+)|(\\/\\*)((?:[^\\*]|(?:\\*)++[^\\/])*+((?:\\*)++\\/)))+)|(?:\\b)|(?=\\W)|(?<=\\W)|(?:\\A)|(?:\\Z)))(#)(?:(?:\\s)+)?((?:(?:ifndef|ifdef)|if))",

I applied the suggested patch there and found it resulted in the expected highlighting.