Classic injection constructor parser fails with static method

[aleho]

Dependency injection fails here with parsing the constructor arguments.

The example below is able to reconstruct this problem:

const awilix = require('awilix');


class Service1 {
    /**
     * This constructor is parsed correctly.
     *
     * @param {function} injectedService
     */
    constructor(injectedService) {
        injectedService(this);
    }
}

class Service2 {
    /**
     * Comment out the return statement and parsing works again.
     *
     * @param {string} aParam
     */
    static someStaticMethod(aParam) {
        return typeof aParam !== 'undefined' ? aParam : 'no param';
    }

    /**
     * This constructor fails because of the static method above.
     *
     * @param {function} injectedService
     */
    constructor(injectedService) {
        console.log(Service2.someStaticMethod(this));
        injectedService(this);
    }
}



const container = awilix.createContainer({
    injectionMode: awilix.InjectionMode.CLASSIC,
});

container.register({
    injectedService: awilix.asFunction(() => instance => console.log(instance.constructor.name)),
    service1:        awilix.asClass(Service1),
    service2:        awilix.asClass(Service2),
});


container.resolve('service1');
container.resolve('service2');

npm list:

awilix-test@1.0.0 /home/alex/Dev/test
└─┬ awilix@4.2.1
  ├─┬ camel-case@3.0.0
  │ ├─┬ no-case@2.3.2
  │ │ └── lower-case@1.1.4
  │ └── upper-case@1.1.3
  └─┬ glob@7.1.3
    ├── fs.realpath@1.0.0
    ├─┬ inflight@1.0.6
    │ ├── once@1.4.0 deduped
    │ └── wrappy@1.0.2
    ├── inherits@2.0.3
    ├─┬ minimatch@3.0.4
    │ └─┬ brace-expansion@1.1.11
    │   ├── balanced-match@1.0.0
    │   └── concat-map@0.0.1
    ├─┬ once@1.4.0
    │ └── wrappy@1.0.2 deduped
    └── path-is-absolute@1.0.1

[jeffijoe]

Thanks for the report! I'll look into this!

As a temporary workaround you can move the static method below the constructor.

[jeffijoe]

I've identified the cause and have pushed v4.2.2 which contains the fix.

The issue was the tokenizer trying to be smart about skipping expressions (used for parsing default arguments), but it saw the = in !== and skipped over the constructor.

The solution was to add a "dumb-mode" flag to the tokenizer that the parser can toggle while skipping to the constructor token.

Let me know how it works!

[aleho]

You're faster than I can npm update! Insane.

Yes, works for me now. Thank you!

[jeffijoe]

Haha, I actually had the fix 20 minutes after you reported it, but since Node v12 was released the Travis build failed (uses stable) so also had to fix v12 compatibility in the same release. 😄

[minhajuddinkhan]

The issue seems to be reproducing itself on the latest version (awilix@4.3.4)

const awilix = require('awilix');

const container = awilix.createContainer({ injectionMode: awilix.InjectionMode.PROXY })

class One {
    constructor({ }) { }
    static hey() { console.log("HEY!") }
}

class Two {
    constructor({ one }) {
        console.log(one.hey); //prints undefined
    }
}

container.register({
    one: awilix.asClass(One),
    two: awilix.asClass(Two),
})


container.resolve('two')

Am I doing something wrong here? :/

[jeffijoe]

@minhajuddinkhan are you using a transpiler?

EDIT: Nevermind. You are using PROXY but this issue is for CLASSIC. However your issue is that you are accessing a static method as if it was an instance method. Make it non-static or use one.constructor.hey()

[minhajuddinkhan]

Thankyou! this solves the issue :)