Incompatibility with ES5-Shim

[sobrinho]

Cross-posting from es-shims/es5-shim#480

Pinned the issue to spreading an object that without es5-shim does work.

[ljharb]

What seems like is happening is that awilix is reflecting on a Module Namespace object using Object.keys or similar, and is passing the result into require, but failing to filter out Symbols (like Symbol.toStringTag).

[jeffijoe]

Symbols are valid keys in Awilix.

It looks like es5-shim is attempting to stringify the cradle which a non-shimmed environment wouldn't do when performing a spread.

I think it makes sense to fix this on the Awilix side, I wasn't aware of this symbol until now. Pretty neat!

Given that its purpose is to do dynamic DI (an unidiomatic thing in JS)

@ljharb not sure what this means 🙂 If you mean relying on a proxy, that's only required for browser-based apps that are minified in production unless you don't mangle your parameter names. My recommendation is always to use Classic mode when possible.

[ljharb]

Symbols are valid object keys, but not a valid require path in node or bundlers.

[jeffijoe]

It's not calling require though. The error that is thrown is not related to require, it's indicating a missing registration in the container. In fact, all "dynamic" module stuff is stripped out in the browser build.

[ljharb]

aha, thanks, that was what i was confused about. appreciate the fix.

[jeffijoe]

Fixed in v7.0.0 which has been released to npm.