Skip to content

Use except Exception instead of bare except in validate_metadata.py #1655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonesbusy merged 1 commit into from
Mar 23, 2026
Merged

Use except Exception instead of bare except in validate_metadata.py #1655

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions scripts/validate_metadata.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ def validate_metadata(file_path):
repo_name = metadata['pluginRepository'].replace('https://github.com/', '').replace('.git', '')
try:
g.get_repo(repo_name)
except:
except Exception:
pr.create_issue_comment(f"Invalid plugin repository '{metadata['pluginRepository']}' in {file_path}")
raise ValueError("Invalid plugin repository")

Expand All @@ -148,7 +148,7 @@ def validate_metadata(file_path):
if pr_status and pr_status != actual_status:
pr.create_issue_comment(f"PR status mismatch in {file_path}: metadata says '{pr_status}', but actual status is '{actual_status}'")
raise ValueError("PR status mismatch")
except:
except Exception:
pr.create_issue_comment(f"Unable to fetch PR '{pr_url}' in {file_path}")
raise ValueError("Invalid PR")

Expand Down
Loading