Skip to content

fix: propagate verification failures instead of silently swallowing them #1711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonesbusy merged 3 commits into from
Apr 18, 2026
Merged

fix: propagate verification failures instead of silently swallowing them #1711

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4ab2a04
Fix: Skip modernization metadata collection in dry-run mode
Fikri-20 Apr 11, 2026
dda32bf
fix: propagate verification failures instead of silently swallowing them
Fikri-20 Apr 12, 2026
5bc736c
fix: allow dry-run to show diff even when post-modernization verify f…
Fikri-20 Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions ...izer-core/src/main/java/io/jenkins/tools/pluginmodernizer/core/impl/PluginModernizer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,9 +359,14 @@ private void process(Plugin plugin) {

if (plugin.hasErrors()) {
LOG.warn(
"Skipping plugin {} due to verification errors after modernization. Check logs for more details.",
"Plugin {} failed verification after modernization. Check logs for more details.",
plugin.getName());
return;
if (!config.isDryRun()) {
return;
}
// In dry-run mode we are only previewing changes, so clear the error and
// continue so the diff is still displayed to the user.
plugin.withoutErrors();
}

// Recollect metadata after modernization
Expand Down Expand Up @@ -419,12 +424,10 @@ private void process(Plugin plugin) {
plugin.addError("Unexpected processing error. Check the logs at " + plugin.getLogFile(), e);
}
} finally {
if (!config.isSkipMetadata() && !earlySkip) {
if (!config.isSkipMetadata() && !earlySkip && !config.isDryRun()) {
try {
// collect the modernization metadata and push it to metadata repository if valid
collectModernizationMetadata(plugin);
validateModernizationMetadata(plugin);
// Only proceed with metadata operations if modernization metadata was successfully created
if (plugin.getModernizationMetadata() != null) {
plugin.fetchMetadata(ghService);
plugin.forkMetadata(ghService);
Expand Down Expand Up @@ -599,10 +602,8 @@ private JDK verifyPlugin(Plugin plugin) {
plugin.format(mavenInvoker);
plugin.verify(mavenInvoker);
if (plugin.hasErrors()) {
LOG.info("Plugin {} failed to verify with JDK {}", plugin.getName(), jdk.getMajor());
plugin.withoutErrors();
LOG.warn("Plugin {} failed to verify with JDK {}", plugin.getName(), jdk.getMajor());
}
plugin.withoutErrors();

return jdk;
}
Expand Down
Loading