fix: use configured cache path in getDiffStats instead of hardcoded default#1712
Merged
jonesbusy merged 1 commit intojenkins-infra:mainfrom Apr 18, 2026
Merged
Conversation
…efault getDiffStats() resolved the plugin's .git directory from Settings.DEFAULT_CACHE_PATH regardless of the --cache-path option or CACHE_DIR environment variable. Any run with a custom cache path would fail with 'Failed to get diff stats' and report zero additions/deletions in the modernization metadata. Replace the hardcoded constant with config.getCachePath() so the correct cache location is always used.
jonesbusy
approved these changes
Apr 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getDiffStats()was resolving the .git directory againstSettings.DEFAULT_CACHE_PATHinstead ofconfig.getCachePath(). So running with--cache-path /tmp/my-cachewould clone the plugin correctly there but then fail to read it back when building the PR description. One-line fix.Testing Done
I tested it locally, and here is the before and after
Before (
main—GHServiceTest):After (
fix/get-diff-stats-cache-path—mvn clean test -pl plugin-modernizer-core):Submitter checklist