Add our recipe model and remove OpenRewrite from CLI dependency#446
Merged
Conversation
jonesbusy
force-pushed
the
feature/optimize-jar-2
branch
2 times, most recently
from
aeeb14b to
3027e8f
Compare
jonesbusy
force-pushed
the
feature/optimize-jar-2
branch
from
3027e8f to
7d969f0
Compare
jonesbusy
force-pushed
the
feature/optimize-jar-2
branch
from
7d969f0 to
9647b0d
Compare
jonesbusy
added
the
enhancement
jonesbusy
added
chore
and removed
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove direct dependency with OpenRewrite and avoid using internals outsides recipes.
So we can exclude all OpenRewrite jar when packaging CLI
Jar is now 25Mib with this PR
Closes #435
I think it will stop the optimization there. It's good enough