chore(updatecli): Update the compress-api plugin version#475
Merged
Conversation
Collaborator
|
Thanks. We need to be careful with this update. Adding outdated version was done in purpose. 1.27.1-1 depends on 2.489 because it corresponds the the weekdly that detached the dependency I think we need to put this PR on-hold until 2.489 is the recommanded baseline version (at at least latest LTS) |
Collaborator
Author
|
Sure thing! |
Collaborator
|
Maybe we can merge it and just not merge the updatecli PR ? |
Collaborator
Author
|
Why not, if you don't mind the noise... |
Collaborator
|
That's ok. In any case we need to work on conditions : #320 Either without or own logic or using openrewrite https://docs.openrewrite.org/recipes/maven/search/finddependency |
jonesbusy
approved these changes
Dec 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #471.
A new Updatecli configuration file
compress-api.yamlhas been introduced to automate version updates for thecommons-compress-api-plugin. The configuration defines a process to fetch the latest plugin version from GitHub releases, automatically update the version in therecipes.ymlfile, and create a pull request with the new version details.Changes
updatecli/updatecli.d/compress-api.yamlTesting done
updatecli diff --debug --config ./updatecli/updatecli.d/compress-api.yaml --values ./updatecli/values.github-action.yaml 2>&1which produced:
--- ./plugin-modernizer-core/src/main/resources/META-INF/rewrite/recipes.yml
+++ ./plugin-modernizer-core/src/main/resources/META-INF/rewrite/recipes.yml
@@ -142,7 +142,7 @@
pluginGroupId: io.jenkins.plugins
pluginArtifactId: commons-compress-api
# TODO: version from bom and filtered here ? or managed by renovate ?
Submitter checklist