Add API plugin and condition for recipes#485
Merged
Merged
Conversation
dd8bb5c to
012dc75
Compare
gounthar
approved these changes
Dec 19, 2024
012dc75 to
68d7cd2
Compare
Collaborator
Author
|
Putting in draft to fix tests and cleanup log files |
7bdaa12 to
986bace
Compare
986bace to
8cff607
Compare
Collaborator
Author
|
All green. Was not flaky test but due to the "logs" folder empty on my environment and was not created by the test if not present |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the end I don't think we need a custom solution for condition
We can easily implement a search recipe (that read or own metadata for example) and use it as conditional for recipes
Fix #320
Possible fix of #476
Testing done
Automated tests and tested the result of the pom for new recipes
Submitter checklist