Copy metadata to cache instead of moving it#495
Merged
jonesbusy merged 2 commits intoDec 22, 2024
Conversation
…are of cache or external storage
19abace to
a8da6e6
Compare
a8da6e6 to
7645af5
Compare
Collaborator
Author
|
Still evaluating if the search flag is relevant to print the search result back to code. I will most likely keep the Marker implementation for the plugin metadata and remove the search result. This is because scanning recipes cannot be used as preconditions. So it means we will need to add the recipe as a first recipe of each declarative recipes. The IsUsingBom condition has been adapted to use this approach |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Idea is to not "manually" perform metadata collection before a recipes but add is as a first recipe.
So that later recipes applied on the trees can lookup for the marker instead of relying of ready manually the data from any storage
The build-metadata` will remains to force the rebuild on populate the local storage
Testing done
Automated tests
Submitter checklist