Skip to content

Copy metadata to cache instead of moving it#495

Merged
jonesbusy merged 2 commits into
jenkins-infra:mainfrom
jonesbusy:feature/copy-metadata-instead
Dec 22, 2024
Merged

Copy metadata to cache instead of moving it#495
jonesbusy merged 2 commits into
jenkins-infra:mainfrom
jonesbusy:feature/copy-metadata-instead

Conversation

@jonesbusy
Copy link
Copy Markdown
Collaborator

  • Copy metadata to cache instead of moving it
  • Add attribute on recipe to force the rebuild
  • Store the metadata on the pom.xml so it can be consumed

Idea is to not "manually" perform metadata collection before a recipes but add is as a first recipe.

So that later recipes applied on the trees can lookup for the marker instead of relying of ready manually the data from any storage

The build-metadata` will remains to force the rebuild on populate the local storage

Testing done

Automated tests

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@jonesbusy jonesbusy force-pushed the feature/copy-metadata-instead branch 4 times, most recently from 19abace to a8da6e6 Compare December 21, 2024 20:28
@jonesbusy jonesbusy force-pushed the feature/copy-metadata-instead branch from a8da6e6 to 7645af5 Compare December 21, 2024 20:52
@jonesbusy jonesbusy marked this pull request as ready for review December 21, 2024 21:03
@jonesbusy
Copy link
Copy Markdown
Collaborator Author

jonesbusy commented Dec 21, 2024

Still evaluating if the search flag is relevant to print the search result back to code.

I will most likely keep the Marker implementation for the plugin metadata and remove the search result.

This is because scanning recipes cannot be used as preconditions. So it means we will need to add the recipe as a first recipe of each declarative recipes.

The IsUsingBom condition has been adapted to use this approach

@jonesbusy jonesbusy closed this Dec 22, 2024
@jonesbusy jonesbusy reopened this Dec 22, 2024
@jonesbusy jonesbusy merged commit 8419e34 into jenkins-infra:main Dec 22, 2024
@jonesbusy jonesbusy deleted the feature/copy-metadata-instead branch December 22, 2024 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant