Skip to content

Handle special case for analysis-pom-plugin parent#541

Merged
jonesbusy merged 1 commit into
jenkins-infra:mainfrom
jonesbusy:feature/handle-case-of-analysis-pom-plugin
Dec 30, 2024
Merged

Handle special case for analysis-pom-plugin parent#541
jonesbusy merged 1 commit into
jenkins-infra:mainfrom
jonesbusy:feature/handle-case-of-analysis-pom-plugin

Conversation

@jonesbusy
Copy link
Copy Markdown
Collaborator

There is few plugin using a custom parent https://github.com/jenkinsci/analysis-pom-plugin/

Testing done

Add tests

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@jonesbusy jonesbusy force-pushed the feature/handle-case-of-analysis-pom-plugin branch 3 times, most recently from 15eb2f2 to 83f9f66 Compare December 30, 2024 14:26
@jonesbusy jonesbusy force-pushed the feature/handle-case-of-analysis-pom-plugin branch from 83f9f66 to f75c89d Compare December 30, 2024 14:49
@jonesbusy jonesbusy marked this pull request as ready for review December 30, 2024 15:38
@jonesbusy
Copy link
Copy Markdown
Collaborator Author

Need probably more test. But at least now we are able to detect the correct parent and bom used by the analysis-pom

@jonesbusy jonesbusy merged commit 230d189 into jenkins-infra:main Dec 30, 2024
@jonesbusy jonesbusy deleted the feature/handle-case-of-analysis-pom-plugin branch December 30, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant