feat(jte): Add explanation about removal of developers section#789
Merged
Conversation
Add explanation for removing `developers` section when applying `UpgradeNextMajorParentVersion` recipe. * **New Partial Template:** - Add `plugin-modernizer-core/src/main/jte/partials/remove-developers-tag.jte` to include common text about the removal of the `developers` tag. * **Update PR Body for `RemoveDevelopersTag`:** - Modify `plugin-modernizer-core/src/main/jte/pr-body-RemoveDevelopersTag.jte` to include the new partial template using the `include` directive. * **Update PR Body for `UpgradeNextMajorParentVersion`:** - Modify `plugin-modernizer-core/src/main/jte/pr-body-UpgradeNextMajorParentVersion.jte` to include the new partial template using the `include` directive.
Add explanation for removing `developers` section when applying `UpgradeNextMajorParentVersion` recipe. * **New Partial Template:** - Add `plugin-modernizer-core/src/main/jte/partials/remove-developers-tag.jte` to include common text about the removal of the `developers` tag. * **Update PR Body for `RemoveDevelopersTag`:** - Modify `plugin-modernizer-core/src/main/jte/pr-body-RemoveDevelopersTag.jte` to include the new partial template using the `include` directive. * **Update PR Body for `UpgradeNextMajorParentVersion`:** - Modify `plugin-modernizer-core/src/main/jte/pr-body-UpgradeNextMajorParentVersion.jte` to include the new partial template using the `include` directive.
…e> but was: <false>.
…e> but was: <false>.
jonesbusy
approved these changes
Feb 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #788. I would have loved to work with partial templates so we can reuse them in different contexts, but I failed with
@includeand@template. 🤷Add explanation for removing
developerssection when applyingUpgradeNextMajorParentVersionrecipe.plugin-modernizer-core/src/main/jte/partials/remove-developers-tag.jteto include common text about the removal of thedeveloperstag.RemoveDevelopersTag:plugin-modernizer-core/src/main/jte/pr-body-RemoveDevelopersTag.jteto include the new partial template using theincludedirective.UpgradeNextMajorParentVersion:plugin-modernizer-core/src/main/jte/pr-body-UpgradeNextMajorParentVersion.jteto include the new partial template using theincludedirective.Testing done
java -jar plugin-modernizer-cli/target/jenkins-plugin-modernizer-999999-SNAPSHOT.jar run --plugins test-results-analyzer --recipe UpgradeNextMajorParentVersionwhich leads to jenkinsci/log-parser-plugin#153 .Submitter checklist