Move recipe Replace Libraries With Api Plugin

[CodexRaunak]

Issue #637
Moved the Recipe ReplaceLibrariesWithApiPlugin in the plugin-modernizer-tool recipes. Exclusions are not added for libraries that the API plugin handles, as the API plugin is designed to bring those dependencies to the consumer.

Testing done

Added the same pom.xml as a test case where the duplicate tag issue was occurring.

Submitter checklist

• Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
• Ensure that the pull request title represents the desired changelog entry
• Please describe what you did
• Link to relevant issues in GitHub or Jira
• Link to relevant pull requests, esp. upstream and downstream changes
• Ensure you have provided tests - that demonstrates feature works or fixes the issue

[CodexRaunak]

Need a review on this,
I added the same pom.xml as a test case where it was adding duplicate tags #637. The exclusions are not added now at all in json-api. But its skipping the exclusions for every library that is a part of API plugin. I am not sure we want that? Also it needs more tests.

if (isApiProvidedLibrary(groupId, artifactId)) {
                                   continue; // Skip exclusions if the library is already part of the API plugin
 }

Thank you

[jonesbusy]

Let's be careful with target bom version since it's moving every week.

Better to use Settings.getBomVersion() where possible

[CodexRaunak]

I think we don't need it here as we are not upgrading the jenkins version and not tracking the weekly release line.

[jonesbusy]

Hi,

Thanks!

I think we should not exclude anything comming from an API plugin.

Genearally they are used with a BOM, so we should not have dependency convergence issue

I think the situation is much better now than it was originally

[CodexRaunak]

The recipe is not excluding anything from the API plugin, added unit tests for the same