Skip to content

Fix a NullPointerException when no groupId is provided #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hatxet wants to merge 1 commit into from
Closed

Fix a NullPointerException when no groupId is provided #86

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/main/java/com/checkmarx/jenkins/CxScanBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1318,7 +1318,9 @@ private CxScanConfig resolveConfiguration(Run<?, ?> run, DescriptorImpl descript
} else {
ret.setProxy(false);
}
teamPath = getTeamNameFromId(cxConnectionDetails, descriptor, groupId);
if (teamPath == null) {
teamPath = getTeamNameFromId(cxConnectionDetails, descriptor, groupId);
Copy link
Copy Markdown
Member

@scurvydoggo scurvydoggo Jan 3, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this actually fix the issue?

The title of the PR says "when no groupId is provided", however here it is testing teamPath for null, and continuing to use groupId as a parameter.

Copy link
Copy Markdown
Member

@scurvydoggo scurvydoggo Jan 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind, it looks good to me, based on your description

This fix prevents the CxCommonClient from throwing a NullPointerException when the groupId is null if the teamPath parameter has some value.

So the idea is to skip this step if the teamPath is already set with something.

}
//project
ret.setProjectName(env.expand(projectName.trim()));
ret.setTeamPath(teamPath);
Expand Down