Skip to content

Commit / tag on failure#132

Closed
rskang wants to merge 1 commit intojenkinsci:masterfrom
rskang:tag-on-failure
Closed

Commit / tag on failure#132
rskang wants to merge 1 commit intojenkinsci:masterfrom
rskang:tag-on-failure

Conversation

@rskang
Copy link
Copy Markdown

@rskang rskang commented Jan 6, 2015

Also shows names as well as IDs in the Build Data section

Code by @djl197 I just merged it onto a more current master

Review on Reviewable

Tag on failure
9379f15 
Also shows names as well as IDs in the Build Data section

Code by @djl197 I just merged it onto a more current master
@rskang rskang mentioned this pull request Jan 6, 2015
Closed
@KostyaSha
Copy link
Copy Markdown
Member

KostyaSha commented Jan 20, 2015

It doesn't cover all use cases, job status can be also Unstable. Some hetero list with dropdown cases should resolve it more dynamic and modular instead hardcoded checkboxes.

@KostyaSha KostyaSha mentioned this pull request Jan 20, 2015
Closed
@magnayn
Copy link
Copy Markdown
Contributor

magnayn commented Jan 20, 2015

Yep - this would be good (something we've found we need too, where a unit test fails it'd still be nice to pull the container to figure out why).

@rskang
Copy link
Copy Markdown
Author

rskang commented Jan 20, 2015

Yep. Selecting a threshold or a multi-select box to cover all cases is a much better idea.

@electrical electrical mentioned this pull request Mar 19, 2015
Closed
KostyaSha
KostyaSha reviewed Mar 19, 2015
View reviewed changes
Comment thread src/main/java/com/nirima/jenkins/plugins/docker/DockerJobProperty.java
Copy link
Copy Markdown
Member

@KostyaSha KostyaSha Mar 19, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use getBoolean method?

@KostyaSha
Copy link
Copy Markdown
Member

KostyaSha commented Mar 22, 2015

#181 related

@KostyaSha KostyaSha self-assigned this Apr 23, 2015
@KostyaSha KostyaSha added the tag label Apr 24, 2015
@KostyaSha KostyaSha removed their assignment Oct 14, 2015
@pjdarton
Copy link
Copy Markdown
Member

pjdarton commented Jan 28, 2020

Closing due to inactivity.

@pjdarton pjdarton closed this Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rskang @KostyaSha @magnayn @pjdarton