[JENKINS-38608] Report clearly if the Repo URL is empty #821
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkEWaite
requested changes
Jan 22, 2020
MarkEWaite
approved these changes
Jan 22, 2020
There was a problem hiding this comment.
Sorry for the belated review. Thanks @rishabhBudhouliya for following Mark's suggestions and opening this new PR!
|
Hi @rishabhBudhouliya . I noticed that you have troubles with creating a Jenkins Jira account. If it is still an issue, please contact me in https://gitter.im/jenkinsci/gsoc-sig |
@fcojfernandez No issues! Thank you for reviewing it.
Hi @oleg-nenashev , contacting you on Gitter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JENKINS-38608 Report clearly if repo URL is empty
See #820 for the original discussion related to fixing this particular bug.
See #820 (comment) to understand the fix.
Since UserRemoteConfig URL can't be null for many reasons, we arrived at the conclusion of improving the error message to