-
-
Notifications
You must be signed in to change notification settings - Fork 9.1k
Fix word breaking in pre tags and help classes #10881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Yay, your first pull request towards Jenkins core was created successfully! Thank you so much! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks sensible, thanks
Re-running some CI/CD checks due to some failed flaky tests earlier |
For the ERROR:
Unexpected deprecated keyword "break-word" for property "word-break" (declaration-property-value-keyword-no-deprecated) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable, thanks!
…ow-wrap: anywhere` and `word-break: normal`
/label ready-for-merge This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Congratulations on getting your very first Jenkins core pull request merged 🎉🥳 |
word-wrap
is an alias foroverflow-wrap
and only has the supported valuesnormal | break-word | anywhere | [initial | inherit | unset | revert | revert-layer]
1.I am assuming the intention in the
pre
styling was to have it set up to break on each word.I have made the same assumption with the
word-break
property for the.help
which only supports the valuesnormal | break-all | keep-all | manual | auto-phrase | break-word | [initial | inherit | unset | revert | revert-layer]
2.Testing done
Manual visual regression check
Proposed changelog entries
word-wrap
andword-break
CSS properties to use supported values.Proposed changelog category
/label web-ui, bug
Proposed upgrade guidelines
N/A
Submitter checklist
@Restricted
or have@since TODO
Javadocs, as appropriate.@Deprecated(since = "TODO")
or@Deprecated(forRemoval = true, since = "TODO")
, if applicable.eval
to ease future introduction of Content Security Policy (CSP) directives (see documentation).Desired reviewers
@jenkinsci/sig-ux
Before the changes are marked as
ready-for-merge
:Maintainer checklist
upgrade-guide-needed
label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidate
to be considered (see query).Footnotes
https://developer.mozilla.org/en-US/docs/Web/CSS/overflow-wrap#syntax ↩
https://developer.mozilla.org/en-US/docs/Web/CSS/word-break#syntax ↩