Prepare for sunset icon removal from core#1245
Merged
jamietanna merged 1 commit intojenkinsci:masterfrom Jan 1, 2022
Merged
Conversation
jamietanna
approved these changes
Dec 26, 2021
Contributor
jamietanna
left a comment
jamietanna
left a comment
There was a problem hiding this comment.
Looks good - I'll get this merged + released next week, likely before New Year 🙌
6 tasks
Contributor
|
As you've noticed, this is now released 🙌 |
Member
Author
|
Yup, thanks for the quick merge and release 👏🏻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a preparation for
https://github.com/jenkinsci/jenkins/pull/5778/which removes sunset PNG and GIF icons.@jamietanna Would be nice if you can also trigger a release after merging this PR. The core PR is blocked until then.
Thanks in advance!
To note, the required change is the warning icon in
job-dsl-plugin/src/main/resources/javaposse/jobdsl/plugin/actions/SeedJobAction/jobMain.jelly, moving from a PNG to SVG icon is in my opinion nice to have, considering it aligns well with the modern Jenkins UI.The SVG shares the same source like the PNG, therefore the license has not been modified.
The change proposed works well the newest weekly release:
as on the plugin baseline:
