Fix unit tests in latest BOM builds#1542
Merged
basil merged 4 commits intojenkinsci:masterfrom Apr 14, 2025
Merged
Conversation
cg-lib is a dead project that does not support recent JDK versions. This switches to create stubs in spock with byte-buddy. The PR does not directly depend on byte-buddy but rather obtains it transitively via the managed dependency of mockito in the plugin-pom. This allows it to be kept more up-to-data and in a compatable version (as it also brings in the Objenisis version at a know good version).
This reverts commit 19ffc4d.
jtnord
commented
Apr 14, 2025
basil
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jenkinsci/jackson2-api-plugin#272 (comment)
spockhas the ability to switch the library used for mocking based on its classpath.So remove the obsolete cg-lib library and add byte-buddy (transitivly)
Testing done
Tested in CI, validated that the tests failed when using the latest jackson2 version, and pass with the fix.
Submitter checklist