[gilgameshfreedom]

Currently, the s3-plugin plugin deletes the artifacts from S3 only if the corresponding build has been deleted. However, if a job (pipeline) is deleted, the artifacts that were uploaded to S3 by its builds will remain there indefinitely (unless they are manually deleted from S3).

For example, in our environment we actively use the plugin with multi-branch pipelines - for every PR a pipeline is created automatically. When the PR is closed, the corresponding pipeline is deleted automatically, but the artifacts are still kept on S3. As a result, we accumulate a lot of unnecessary data and we need to clean them manually.

This PR adds a new option to the S3 profile - deleteArtifactsRecursively. When enabled (by default it's false), the plugin deletes the artifacts recursively if a pipeline (or a folder / organization folder) is deleted.

[gilgameshfreedom]

@rsandell @olamy @basil please have a look at PR.

[gilgameshfreedom]

The PR check build is failed, but it looks like it happened not because of my changes

22:44:52  ERROR: Issue with creating launcher for agent EC2 (aws-us-east-2) - Spot Windows 2019 x86_64 with JDK21 (i-03c817627f6073e57). The agent has not been fully initialized yet

[gilgameshfreedom]

• @alecharp @batmat @dmbeer @fcojfernandez

Please review the PR someone.

[alecharp]

From a code point of view, this looks ok.
I haven't tested the code and don't have the infra to do so.

[alecharp]

Please, don't force push on pull request where someone started to review the content.

[alecharp]

Please, don't force push on pull request where someone started to review the content.

[gilgameshfreedom]

Please, don't force push on pull request where someone started to review the content.

Ok. Won't do it in the future.

[gilgameshfreedom]

Hi @alecharp. Since the PR was approved may you merge it to trigger a new release?

[gilgameshfreedom]

Hi @rsandell or maybe you could merge the PR to trigger a build of a new release?

[gilgameshfreedom]

github-merge-queue bot removed this pull request from the merge queue due to failed status checks)

@rsandell it looks like the build has been failed not because of the changes in that PR and the build's logs are not available anymore to get an exact answer. Maybe the problem was the same like here - https://ci.jenkins.io/job/Plugins/job/s3-plugin/view/change-requests/job/PR-349/1/

May I ask you try merging it again?