Repository session was not closed for unexpected exceptions#190
Merged
oleg-nenashev merged 2 commits intojenkinsci:masterfrom Dec 12, 2017
Merged
Repository session was not closed for unexpected exceptions#190oleg-nenashev merged 2 commits intojenkinsci:masterfrom
oleg-nenashev merged 2 commits intojenkinsci:masterfrom
Conversation
Previous code caught two specific checked exceptions and closed the repository session only for those. But RuntimeException could occur as well, so the new pattern will work in all cases where success did not occur.
Contributor
Author
|
A bit of background here is that we're seeing Jenkins keeping SVN repositories locked, but in a non-reproducible way which prevents us opening an issue for it. I found this in a quick audit of the code for improper resource handling. It may not be the issue, but it's at least an issue. I should probably check SVNKit itself too. |
The one problem with editing in GitHub itself is that you can't check before committing. ;)
oleg-nenashev
approved these changes
Jul 4, 2017
Member
oleg-nenashev
left a comment
oleg-nenashev
left a comment
There was a problem hiding this comment.
Looks good to me, IIRC there is a similar change in the proposed PRs
Member
|
Retriggered CI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous code caught two specific checked exceptions and closed the repository session only for those. But RuntimeException could occur as well, so the new pattern will work in all cases where success did not occur.