Expand environment variables in repository URL. by jglick · Pull Request #38 · jenkinsci/subversion-plugin

jglick · 2013-03-01T22:37:07Z

Expand environment variables in repository URL in job confguration during validation check, affecting also entering of credentials.

This should allow you to use the same $JENKINS_HOME contents while switching the physical location of your Subversion server using a startup environment.

(Has no effect when Validate repository URLs up to the first variable name is checked.)

Also expands build variables (e.g. those defined in a containing folder property) when defining SVN_* variables, which would otherwise go unset.

Might solve JENKINS-11667.

…ring validation check, affecting also entering of credentials. This should allow you to use the same $JENKINS_HOME contents while switching the physical location of your Subversion server using a startup environment. (Has no effect when "Validate repository URLs up to the first variable name" is checked.)

buildhive · 2013-03-01T22:53:59Z

Jenkins » subversion-plugin #116 SUCCESS
This pull request looks good
(what's this?)

…rver location.

buildhive · 2013-03-18T17:43:31Z

Jenkins » subversion-plugin #117 UNSTABLE
Looks like there's a problem with this pull request
(what's this?)

buildhive · 2013-03-18T18:04:14Z

Jenkins » subversion-plugin #118 UNSTABLE
Looks like there's a problem with this pull request
(what's this?)

buildhive · 2013-05-24T14:03:26Z

Jenkins » subversion-plugin #131 UNSTABLE
Looks like there's a problem with this pull request
(what's this?)

jglick · 2013-05-24T14:24:59Z

I am not sure what the PerJobCredentialStoreTest.testRemoteBuild failure indicates; all tests pass for me locally. The earlier failure of SubversionSCMTest.testMultipleCredentialsPerRepo suggests to me that the tests are simply unreliable.

jglick · 2013-06-06T12:36:40Z

Actually this is wrong, because getLocations ignores build when env is set. Need to consider both combined.

buildhive · 2013-06-06T12:44:29Z

Jenkins » subversion-plugin #138 UNSTABLE
Looks like there's a problem with this pull request
(what's this?)

…ild). A user reported that $SVN_REVISION_1 etc. were not getting set otherwise.

buildhive · 2013-06-06T13:17:05Z

Jenkins » subversion-plugin #139 SUCCESS
This pull request looks good
(what's this?)

jglick · 2013-06-06T13:42:51Z

@kutzi are you reviewing PRs in this plugin, or should I ask @ndeloof etc.? I am not sure I follow all the logic surrounding variable expansion, so advice from people more familiar with the plugin would be welcome.

kutzi · 2013-06-08T09:45:37Z

Sometimes I review PRs here, but there are several areas which I'm not familiar with, either, and variable expansion is definitely one of them.

buildhive · 2013-06-17T21:53:11Z

Jenkins » subversion-plugin #143 SUCCESS
This pull request looks good
(what's this?)

…g locations for SVN_* variables.

buildhive · 2013-06-17T23:07:52Z

Jenkins » subversion-plugin #144 FAILURE
Looks like there's a problem with this pull request
(what's this?)

jenkinsadmin · 2013-07-07T05:53:48Z

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

…ursive variable substitution.

buildhive · 2013-07-16T21:48:07Z

Jenkins » subversion-plugin #155 UNSTABLE
Looks like there's a problem with this pull request
(what's this?)

jglick · 2013-07-22T13:16:29Z

Reporter of original issue seems satisfied with the current state of this branch.

kutzi · 2013-10-05T17:23:00Z

Better to put the recursive into ModuleLocation#getExpandedLocation(EnvVars)?

Would be possible. On the other hand, this would be less efficient—would need to make a defensive copy of the env argument, and the logic would be needlessly repeated for each location. Also this would make a behavioral change to a lower-level method which is only apparently called from here. So unless there is a particular use case that requires the call to resolve to be pushed down, I think it makes more sense here.

Okay, makes sense

kutzi · 2013-10-07T16:12:51Z

As far as I'm able to understand this, looks fine.
As no one else seems to like to review this and it doesn't seem to break anything, I'm going to merge it

Expand environment variables in repository URL.

jglick · 2013-10-15T17:28:56Z

BTW any plans for a trunk release? (I know the refactoring branch was said to still need some love.)

kutzi · 2013-10-15T19:47:03Z

Done. After I had to skip a version number and lost another hour of my life because of http://jira.codehaus.org/browse/MRELEASE-812 :(

jglick · 2013-10-15T19:51:25Z

Just be thankful your $LOCALE is not tr_TR! (Hint: String.toUpper/LowerCase, ı, İ, all hell breaks loose)

jglick added 2 commits March 18, 2013 13:13

$SVN_REVISION also needs to take into account possibly substituted se…

aa9f9d3

…rver location.

checkRevisionPropertiesSupported also needs to subst env vars.

ba34e12

Different overload now being called.

7c0c0fe

Merge branch 'master' into doCheckRemote-masterEnvVars

7785a9a

Merge branch 'master' into doCheckRemote-masterEnvVars

add273b

jglick reviewed Jun 6, 2013
View reviewed changes

Revised to only use masterEnvVars from getExpandedLocation(AbstractBu…

eb0edaf

…ild). A user reported that $SVN_REVISION_1 etc. were not getting set otherwise.

Merge branch 'master' into doCheckRemote-masterEnvVars

65fe472

Make buildEnvVars take into account non-build variables when computin…

4b120f4

…g locations for SVN_* variables.

jglick added 2 commits July 16, 2013 16:38

Merge branch 'master' into doCheckRemote-masterEnvVars

6819927

Make sure SVN_* variables are set even when SVN location involves rec…

5e006e5

…ursive variable substitution.

jglick mentioned this pull request Jul 22, 2013

Suppress warning for common and apparently harmless case. #47

Merged

jglick mentioned this pull request Oct 4, 2013

[Fixed JENKINS-11667] On Project/Job configuration page, when validating... #52

Closed

kutzi reviewed Oct 5, 2013
View reviewed changes

kutzi added a commit that referenced this pull request Oct 7, 2013

Merge pull request #38 from jglick/doCheckRemote-masterEnvVars

0799ee6

Expand environment variables in repository URL.

kutzi merged commit 0799ee6 into jenkinsci:master Oct 7, 2013

jglick deleted the doCheckRemote-masterEnvVars branch October 7, 2013 17:47

Uh oh!

Conversation

jglick commented Mar 1, 2013

Uh oh!

buildhive commented Mar 1, 2013

Uh oh!

buildhive commented Mar 18, 2013

Uh oh!

buildhive commented Mar 18, 2013

Uh oh!

buildhive commented May 24, 2013

Uh oh!

jglick commented May 24, 2013

Uh oh!

jglick Jun 6, 2013

Choose a reason for hiding this comment

Uh oh!

buildhive commented Jun 6, 2013

Uh oh!

buildhive commented Jun 6, 2013

Uh oh!

jglick commented Jun 6, 2013

Uh oh!

kutzi commented Jun 8, 2013

Uh oh!

buildhive commented Jun 17, 2013

Uh oh!

buildhive commented Jun 17, 2013

Uh oh!

jenkinsadmin commented Jul 7, 2013

Uh oh!

buildhive commented Jul 16, 2013

Uh oh!

jglick commented Jul 22, 2013

Uh oh!

kutzi Oct 5, 2013

Choose a reason for hiding this comment

Uh oh!

jglick Oct 7, 2013

Choose a reason for hiding this comment

Uh oh!

kutzi Oct 7, 2013

Choose a reason for hiding this comment

Uh oh!

kutzi commented Oct 7, 2013

Uh oh!

jglick commented Oct 15, 2013

Uh oh!

kutzi commented Oct 15, 2013

Uh oh!

jglick commented Oct 15, 2013

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants