[JENKINS-61131] Fix broken credentials selection (#116)

albers · web-flow · commit 36166a49d472 · 2020-03-09T16:40:50.000Z
Signed-off-by: Harald Albers &lt;github@albersweb.de&gt;
diff --git a/src/main/java/org/jenkinsci/plugins/vsphere/VSphereConnectionConfig.java b/src/main/java/org/jenkinsci/plugins/vsphere/VSphereConnectionConfig.java
@@ -142,7 +142,7 @@ public ListBoxModel doFillCredentialsIdItems(@AncestorInPath AbstractFolder<?> c
                 @QueryParameter String vsHost) {
             throwUnlessUserHasPermissionToConfigureCloud(containingFolderOrNull);
             return new StandardListBoxModel().includeEmptyValue()
-                .includeMatching(Jenkins.getInstance(), StandardCredentials.class,
+                .includeMatchingAs(ACL.SYSTEM, Jenkins.getInstance(), StandardCredentials.class,
                     Collections.singletonList(getDomainRequirement(vsHost)), CREDENTIALS_MATCHER);
         }
 

Original file line number	Diff line number	Diff line change
`@@ -142,7 +142,7 @@ public ListBoxModel doFillCredentialsIdItems(@AncestorInPath AbstractFolder<?> c`
`142`	`142`	`@QueryParameter String vsHost) {`
`143`	`143`	`throwUnlessUserHasPermissionToConfigureCloud(containingFolderOrNull);`
`144`	`144`	`return new StandardListBoxModel().includeEmptyValue()`
`145`		`- .includeMatching(Jenkins.getInstance(), StandardCredentials.class,`
	`145`	`+ .includeMatchingAs(ACL.SYSTEM, Jenkins.getInstance(), StandardCredentials.class,`
`146`	`146`	`Collections.singletonList(getDomainRequirement(vsHost)), CREDENTIALS_MATCHER);`
`147`	`147`	`}`
`148`	`148`