[JENKINS-61131] Fix broken credentials selection#116
Merged
pjdarton merged 1 commit intojenkinsci:masterfrom Mar 9, 2020
Merged
[JENKINS-61131] Fix broken credentials selection#116pjdarton merged 1 commit intojenkinsci:masterfrom
pjdarton merged 1 commit intojenkinsci:masterfrom
Conversation
jenkinsci#110 changed the population of the credentials selection to no longer use deprecated api. Credentials are now resolved in the context of Jenkins.getAuthentication(), which does not return any matches. According to the documentation of the credentials-plugin, interactive lookups on the main configuration page should be performed as ACL.SYSTEM. Signed-off-by: Harald Albers <github@albersweb.de>
Member
|
Thanks for the fix; much appreciated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes JENKINS-61131.
#110 changed the population of the credentials selection to no longer use deprecated api.
Credentials are now resolved in the context of
Jenkins.getAuthentication(), which does not return any matches.According to the documentation of the credentials-plugin, interactive lookups on the main
configuration page should be performed as
ACL.SYSTEM.Signed-off-by: Harald Albers github@albersweb.de