Adding snapshot deletion functionality#10
Merged
jswager merged 6 commits intojenkinsci:masterfrom Jan 7, 2014
Merged
Conversation
|
plugins » vsphere-cloud-plugin #23 SUCCESS |
point vijava back to com.vmware to remove warning
|
plugins » vsphere-cloud-plugin #24 SUCCESS |
|
plugins » vsphere-cloud-plugin #25 SUCCESS |
|
plugins » vsphere-cloud-plugin #26 SUCCESS |
Contributor
Author
|
vijava 5.0.0 was choking on the consolidate calls when used w/ my 5.1 vSphere instance. Updating the dependency declaration fixed the issue. |
In ALL cases, the return value is checked and an exception is thrown if null. Removing this throw will allow for simpler logic when snapshot existence is checked.
|
plugins » vsphere-cloud-plugin #27 SUCCESS |
jswager
added a commit
that referenced
this pull request
Jan 7, 2014
Adding snapshot deletion functionality
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding simple deletion of a snapshot by name. I'll be testing this in the coming days and will update when ready.