Stop using deprecated Util#join#129
Merged
pjdarton merged 1 commit intojenkinsci:masterfrom May 12, 2022
Merged
Conversation
Member
|
I'm going to hold off merging this until jenkinsci/docker-plugin#855 has proved it is safe. The docker-plugin has much better unit-test coverage (its unit-tests can test that it can spin up new containers, which is possible as the Jenkins CI environment has docker) than this plugin (the Jenkins CI environment doesn't have a vSphere server to test against, so this plugin can't test things "for real") and it's currently failing on the docker-plugin's equivalent PR - I suspect that if the unit-tests were adequate in this plugin, it'd fail here too. |
Member
Author
I suspect not, because this PR is valid and correct. Approve and merge it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This method was deprecated in jenkinsci/jenkins#5467, so migrate away from it in favor of native Java Platform functionality.