added possibility of creating clone without specifying resource pool.#33
added possibility of creating clone without specifying resource pool.#33jswager merged 3 commits intojenkinsci:masterfrom Ichai5:master
Conversation
There was a problem hiding this comment.
This file should not be in this commit.
There was a problem hiding this comment.
You are right,
How can I remove from the pull request ?
There was a problem hiding this comment.
Make a commit to Ichai5:master that deletes the file. The PR will be automatically updated when the change is pushed to GitHub Ichai5:master.
|
Please note that I'm not a developer of this plugin, so my review comments are just offered as advice, nothing more. |
|
@daniel-beck Maybe not a maintainer yet - want to be? Pretty easy to fix that. Your ongoing input has been valuable. |
|
@jswager Thanks, but my plate is full, and I don't use vSphere anyway, so I doubt I'd make a good maintainer. I'm still available if you have specific questions though. |
|
@daniel-beck Reviewing pull requests is always a great way to help! Thanks! |
2. restore doCheckResourcePool to check that resource pool is specified if source is template.
added possibility of creating clone without specifying resource pool.
3 participants
Hi vsphere-cloud-plugin team,
I’m currently need that the cloned VM will be created on the same host as the source.
When I browse the vmware documentation on VirtualMachineRelocateSpec I see that if resource pool is not specified and host also, the current host is used.
So If I have understood, enable cloning the VM without specifying the Resource Pool will clone it to the same host.
For a clone operation from a template to a virtual machine, this pool is required according to the vmWare Doc.
So we can enable cloning a VM without specifying a resource pool when the source is not a template.
Please find the changeset that let me get this feature.
Are these changes acceptable for you ?
If yes can you add them to the next plugin version.
Thanks in advance,
Ichai