Merged
Conversation
slaves do not end up with inappropriate serialised state in their nodes/xxxx/config.xml file. Bugfix: No longer attempts to restart dying cloud slaves to satisfy provisioning demands. Bugfix: No longer uses VSphere.countVms() to judge per-cloud instance cap - uses internal state instead (faster and more reliable) Bugfix: On-startup, now re-discovers slaves that were active before Jenkins restarted, otherwise they don't contribute to the instance cap. Enhancement: When creating a cloud VM, if the slave-creation fails we now try to remove the VM. Enhancement: Added form validation for cloud's max online slaves and instance cap. Enhancement: Improve vSphereCloud logging functions to allow easier logging of exceptions.
VSphere no longer logs to stdout. Improved exception logging - now includes stacktraces. Added extra detail into some textual output for easier diagnosis.
jswager
approved these changes
Sep 16, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bugfix to code written for JENKINS-36878.
That code introduced an unwanted link from slaves to the cloud's transient state which then appeared in the serialised data.
Cloud Slaves now re-discover where they came from when they exit.