[JENKINS-44796] vSphereCloudLauncher enhancement#75
Merged
pjdarton merged 1 commit intojenkinsci:masterfrom Jul 28, 2017
Merged
[JENKINS-44796] vSphereCloudLauncher enhancement#75pjdarton merged 1 commit intojenkinsci:masterfrom
pjdarton merged 1 commit intojenkinsci:masterfrom
Conversation
pjdarton
force-pushed
the
launcher_improvement
branch
from
fe0570c to
0361263
Compare
vSphereCloudLauncher no longer connects to vSphere when its "idleAction" is
"nothing". It still connects as normal if it needs to, it just doesn't bother
connecting when it's not going to use the connection.
It also now calls VSphere's disconnect method from a finally {...} block to
ensure that it will always disconnect from vSphere if it had previously
connected; before, it could remain connected if exceptions happened.
pjdarton
force-pushed
the
launcher_improvement
branch
from
0361263 to
aa4ba8c
Compare
pjdarton
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vSphereCloudLauncher no longer connects to vSphere when its "idleAction" is "nothing". It still connects as normal if it needs to, it just doesn't bother connecting when it's not going to use the connection.
It also now calls VSphere's disconnect method from a finally {...} block to ensure that it will always disconnect from vSphere if it had previously connected; before, it could remain connected if exceptions happened.