Closed
Conversation
The last edit to VSphereCloudRetentionStrategy used CRLF EOLs. This commit changes the end-of-line codes from CRLF to LF - no other changes made.
The existing "keep until it's been idle for too long" strategy didn't appear to be working - VMs would get disposed of immediately after becoming idle. This change replaces the implementation with one that follows the techniques used in the OpenStack plugin, as that one seems to work. So, after this change, we now have a choice between a "use once" strategy or, now this works, we can keep VMs around until they've been unused for too long (which is configurable). This allows us to get a better build throughput as we do not have to wait for VMs to boot up for every build, as VMs remain available for reuse after each build and only get killed off if they remain surplus to requirements for too long.
This was referenced Jul 28, 2017
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing "keep until it's been idle for too long" strategy didn't appear to be working - VMs would get disposed of immediately after becoming idle.
This change replaces the implementation with one that follows the techniques used in the OpenStack plugin, as that one seems to work.
So, after this change, we now have a choice between a "use once" strategy (as before) or, now this works, we can keep VMs around until they've been unused for too long ("too long" is configurable). This allows us to get a better build throughput as we do not have to wait for VMs to boot up for every build, as VMs can remain available for reuse after each build and only get killed off if they remain surplus to requirements for too long.