Merged
Conversation
pom.xml, Deploy.java, ReconfigureNetworkAdapters.java, VSphere.java, VSphereLogger.java used an inconsistent mix of tabs and spaces for indentation - they now use spaces (four per level of indentation). VSphere.java also had a few places where braces were "on the next line" instead of "at end of line".
Removed unused import statements from Clone.java, Delete.java, Deploy.java, PowerOff.java, ReconfigureCpu.java, ReconfigureMemory.java, VSphere.java and vSphereCloudSlaveTemplate.java.
Code was casting AbstractFolderProperty to FolderVSphereCloudProperty and then ignoring the result, repeating the cast on the next line. It now uses the result of the first cast instead of doing it twice and leaving the variable unread.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some Java files use a mix of tabs and spaces, which makes it almost impossible for contributors to "fit in" with the existing code style (as there isn't one). This PR goes some way to making these self-consistent by turning tabs to spaces in Java files that used both. Files which used tabs throughout have not been modified.
Some Java files had unused import statements which caused warnings in my IDE.
One file had an unused local variable.