Merged
Conversation
Add the line <?jelly escape-by-default='true'?> where it's absent. Plus some whitespace changes where we had previously a mix of tabs and spaces.
Removed unnecessary cast. Removed unnecessary import.
Refactored excessively long if/elseif...else clauses as a switch.
Change version of org.jenkins-ci.plugins/plugin from 2.22 to 2.29, which is the last version that works with a Java7 JDK. PR jenkinsci#67 upgraded to 2.30 which is Java8-only, and I'm hoping to avoid that at present.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the line where it's absent in jelly files.
Some whitespace changes where we previously has inconsistency.
Removed unnecessary cast.
Removed unnecessary import.
Refactored excessively long if/elseif...else clauses as a switch.
Change version of org.jenkins-ci.plugins/plugin from 2.22 to 2.29, which is the last version that works with a Java7 JDK, and brings us almost to the 2.30 specified in PR #67.