Update for newer PHP and dependencies #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
now laminas/laminas-diactoros ^2.5 supports PHP 8 |
Bump dev package versions, including PHPUnit
|
I have bumped diactoros to 2.5 and added PHP 8.0 compat in composer, and it all works very nicely, so thanks for the heads-up @edurenye. I also bumped some dev dependencies (inc PHPUnit 9.5) and added the roave/security-advisories package. All tests still pass, including on PHP 8.1. |
|
This other PR also updates this stuff: #90, But this issue is older, so I think this PR should be kept |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the test suite run (successfully) on PHP 7.3. and 7.4, raises the minimum to PHP 7.3 (the oldest currently supported release), and updates various dependencies for more recent versions, in particular PHPUnit 9 and Guzzle 7.
I tried it on PHP 8.0 but it breaks because there is no compatible version of laminas/laminas-diactoros on 8.0 yet so I left that out of this PR, but at least you know where the problems lie.
If this is merged and tagged, I recommend bumping the major version since these updates amount to a BC break.