feat: Added tracing crate #45
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… each with a relative tracing::warn!|tracing::error!.
|
@jBernavaPrah Great, I meant to do it, so this is perfect. Thanks for the clean PR. I'm merging the revert testing commit; I like to have one PR commit per feature. Also, there was leftover Merge coming soon. |
|
@jBernavaPrah Ok, this PR is merged, even if GitHub say otherwise. I had to do pull and merge your two commits, and then did two other cleanup commits. Somehow, github does not recognize this as a merge, so, my best practice is to add the And your commit (af73cea) is in the commit list: So, all good. |
|
PR MERGED (despite GitHub status) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed
println!from src and substituted each with a relative tracing::warn!|tracing::error!.