fix: logger function should accept second arguments#198
Merged
naorpeled merged 1 commit intojeremydaly:mainfrom Dec 20, 2022
Merged
fix: logger function should accept second arguments#198naorpeled merged 1 commit intojeremydaly:mainfrom
naorpeled merged 1 commit intojeremydaly:mainfrom
Conversation
Docs show that we could add a second argument in the logger, it's working fine in JS but in TS the typing was only accepting string arguments
jeremydaly
approved these changes
Jan 6, 2022
Owner
|
Thanks, will get this in the next release. |
Contributor
Author
|
@jeremydaly Any chance of this getting merged soon? |
naorpeled
approved these changes
Dec 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docs show that we could add a second argument in the logger, it's working fine in JS but in TS the typing was only accepting string arguments