Skip to content

Migration Guide #2419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 25, 2019
Merged

Migration Guide #2419

merged 2 commits into from
Jul 25, 2019

Conversation

imiklos
Copy link
Contributor

@imiklos imiklos commented Jul 9, 2018

In this guide we collected informations for you to update the
JerryScript from 1.0 to 2.0.

JerryScript-DCO-1.0-Signed-off-by: Istvan Miklos [email protected]

@akosthekiss
Copy link
Member

It might be just me, but this rather looks to me as a migration guide with all the code snippets and links to documentation, not as a release note. Which is no bad thing to have, just should be called by its proper name, IMO. Release notes are more compact in my experience.

@imiklos
Copy link
Contributor Author

imiklos commented Jul 9, 2018

@akosthekiss Good point, I will rename it.

@imiklos imiklos changed the title [WIP] Release Notes [WIP] Migration Guide Jul 9, 2018
@akosthekiss akosthekiss added the documentation Related to documentation label Aug 17, 2018
@LaszloLango
Copy link
Contributor

@imiklos there are a few new API changes. Could you update the PR?

@imiklos
Copy link
Contributor Author

imiklos commented Sep 3, 2018

@LaszloLango Thank you! I've updated the PR.

@LaszloLango
Copy link
Contributor

Please add #2540 to the guide

@LaszloLango
Copy link
Contributor

Please add #2599 to the guide

Copy link
Contributor

@legendecas legendecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add #2814 to the guide

@LaszloLango LaszloLango force-pushed the patch_notes branch 2 times, most recently from 60ab863 to a019206 Compare May 23, 2019 09:20
@galpeter
Copy link
Contributor

@dbatyai I've updated the PR

Istvan Miklos and others added 2 commits July 25, 2019 15:37
Migration guide from JerryScript 1.0 to 2.0.

Co-authored-by: László Langó [email protected]
Co-authored-by: Peter Gal [email protected]
JerryScript-DCO-1.0-Signed-off-by: Istvan Miklos [email protected]
For each API method/type the documentation now includes
the version it was introduced or a change occured.

JerryScript-DCO-1.0-Signed-off-by: Peter Gal [email protected]
@dbatyai dbatyai changed the title [WIP] Migration Guide Migration Guide Jul 25, 2019
Copy link
Member

@dbatyai dbatyai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dbatyai dbatyai requested a review from rerobika July 25, 2019 15:15
Copy link
Member

@rerobika rerobika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rerobika rerobika merged commit 7575fa4 into jerryscript-project:master Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Related to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants