-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Update tcell dependency #5192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tcell dependency #5192
Conversation
This provides two fixes: - proper handling of keypad keys on certain terminals (e.g. iTerm2) - fix problems pasting certain emojis or east asian text on Windows Terminal
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesFootnotes
|
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [jesseduffield/lazygit](https://github.com/jesseduffield/lazygit) | patch | `v0.58.0` → `v0.58.1` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>jesseduffield/lazygit (jesseduffield/lazygit)</summary> ### [`v0.58.1`](https://github.com/jesseduffield/lazygit/releases/tag/v0.58.1) [Compare Source](jesseduffield/lazygit@v0.58.0...v0.58.1) <!-- Release notes generated using configuration in .github/release.yml at v0.58.1 --> This is a hotfix release that fixes the known issues with 0.58. To expand on this a bit: in 0.58 we updated our TUI library tcell to a new version that made significant under-the-hood changes; this allowed us to fix several rendering issues, mostly related to wide characters like some emojis. Apart from that, there are few user visible changes with this update, but it lays the ground for future enhancements like support for more keybindings. However, since the changes are so fundamental it also introduced a number of regressions, and I'm not really surprised about that. Most of these were bugs in tcell that have been fixed upstream now, but some were on our side. This release fixes the ones I know about. If you still have issues, please report them! #### What's Changed ##### Enhancements 🔥 - Update search position (match x of y) when changing the selection in a list view by [@​stefanhaller](https://github.com/stefanhaller) in [#​5169](jesseduffield/lazygit#5169) ##### Fixes 🔧 - When doing ctrl-f, and the resulting commit is not visible, scroll it into view by [@​stefanhaller](https://github.com/stefanhaller) in [#​5182](jesseduffield/lazygit#5182) - Fix pasting multi-line text into the commit description by [@​stefanhaller](https://github.com/stefanhaller) in [#​5186](jesseduffield/lazygit#5186) - Fix keypad keys, and pasting emojis in Windows Terminal by [@​stefanhaller](https://github.com/stefanhaller) in [#​5192](jesseduffield/lazygit#5192) - Don't log the "git ls-remote" call when opening a MR by [@​stefanhaller](https://github.com/stefanhaller) in [#​5195](jesseduffield/lazygit#5195) - Fix rendering artefacts after double-width characters (e.g. "⚠️ ") on some terminals by [@​stefanhaller](https://github.com/stefanhaller) in [#​5198](jesseduffield/lazygit#5198) ##### Maintenance ⚙️ - Request info about terminal in issue template by [@​stefanhaller](https://github.com/stefanhaller) in [#​5194](jesseduffield/lazygit#5194) **Full Changelog**: <jesseduffield/lazygit@v0.58.0...v0.58.1> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi43OC4yIiwidXBkYXRlZEluVmVyIjoiNDIuNzguMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90IiwiYXV0b21hdGlvbjpib3QtYXV0aG9yZWQiLCJkZXBlbmRlbmN5LXR5cGU6OnBhdGNoIl19-->
This provides two fixes:
Fixes #5171
Fixes #5173