Update search position (match x of y) when changing the selection in a list view #5169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesFootnotes
|
7 tasks
stefanhaller
force-pushed
the
set-search-x-of-y-when-changing-list-selection
branch
from
418dae0 to
a284e32
Compare
stefanhaller
force-pushed
the
set-search-x-of-y-when-changing-list-selection
branch
from
a284e32 to
516f7f6
Compare
…a list view or in the staging view.
stefanhaller
force-pushed
the
set-search-x-of-y-when-changing-list-selection
branch
from
516f7f6 to
65edd99
Compare
stefanhaller
deleted the
set-search-x-of-y-when-changing-list-selection
branch
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Jan 13, 2026
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [jesseduffield/lazygit](https://github.com/jesseduffield/lazygit) | patch | `v0.58.0` → `v0.58.1` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>jesseduffield/lazygit (jesseduffield/lazygit)</summary> ### [`v0.58.1`](https://github.com/jesseduffield/lazygit/releases/tag/v0.58.1) [Compare Source](jesseduffield/lazygit@v0.58.0...v0.58.1) <!-- Release notes generated using configuration in .github/release.yml at v0.58.1 --> This is a hotfix release that fixes the known issues with 0.58. To expand on this a bit: in 0.58 we updated our TUI library tcell to a new version that made significant under-the-hood changes; this allowed us to fix several rendering issues, mostly related to wide characters like some emojis. Apart from that, there are few user visible changes with this update, but it lays the ground for future enhancements like support for more keybindings. However, since the changes are so fundamental it also introduced a number of regressions, and I'm not really surprised about that. Most of these were bugs in tcell that have been fixed upstream now, but some were on our side. This release fixes the ones I know about. If you still have issues, please report them! #### What's Changed ##### Enhancements 🔥 - Update search position (match x of y) when changing the selection in a list view by [@​stefanhaller](https://github.com/stefanhaller) in [#​5169](jesseduffield/lazygit#5169) ##### Fixes 🔧 - When doing ctrl-f, and the resulting commit is not visible, scroll it into view by [@​stefanhaller](https://github.com/stefanhaller) in [#​5182](jesseduffield/lazygit#5182) - Fix pasting multi-line text into the commit description by [@​stefanhaller](https://github.com/stefanhaller) in [#​5186](jesseduffield/lazygit#5186) - Fix keypad keys, and pasting emojis in Windows Terminal by [@​stefanhaller](https://github.com/stefanhaller) in [#​5192](jesseduffield/lazygit#5192) - Don't log the "git ls-remote" call when opening a MR by [@​stefanhaller](https://github.com/stefanhaller) in [#​5195](jesseduffield/lazygit#5195) - Fix rendering artefacts after double-width characters (e.g. "⚠️ ") on some terminals by [@​stefanhaller](https://github.com/stefanhaller) in [#​5198](jesseduffield/lazygit#5198) ##### Maintenance ⚙️ - Request info about terminal in issue template by [@​stefanhaller](https://github.com/stefanhaller) in [#​5194](jesseduffield/lazygit#5194) **Full Changelog**: <jesseduffield/lazygit@v0.58.0...v0.58.1> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi43OC4yIiwidXBkYXRlZEluVmVyIjoiNDIuNzguMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90IiwiYXV0b21hdGlvbjpib3QtYXV0aG9yZWQiLCJkZXBlbmRlbmN5LXR5cGU6OnBhdGNoIl19-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When searching (not filtering) in a list view using
/, moving the selection now updates the "x of y" indicator of the search results to the last one before the selection. Pressingnagain searches from there rather than from the previously shown result.Also see corresponding gocui PR at jesseduffield/gocui#95.