Check for bare repositories

[nullishamy]

This adds checks for bare repositories, which are unsupported, and errors gracefully if we encounter one.

Related: #2066

[jesseduffield]

Rather than exit the program, it would be better to ask the user if they want to open lazygit anyway, to the most recently opened repo. E.g.:

You've attempted to open Lazygit in a bare repo but Lazygit does not yet support bare repos. Open most recent repo? Y/N

If the user presses Y, then we'll do the same thing we currently do when the user opens lazygit in a non-repo and chooses not to initialise a new one. Otherwise, we'll exit the program.

Another point: we should move the message into pkg/i18n/english.go so that it can be translated into other languages (don't worry, you don't need to actually do any translating in this PR, it just makes things easier for others who want to add translations).

Lemme know if you need any pointers :)

[nullishamy]

Yeah i wasnt sure how to handle the case where we need to exit, but just left it for review because its not a huge deal to change. Also wasnt sure how to operate the i18n, but judging from existing usage it shouldn't be too hard. Will work on this soon.

[nullishamy]

I'm not sure if we should factor out the "switch to a recent repo" logic or not, thoughts?

[mark2185]

I'm not sure if we should factor out the "switch to a recent repo" logic or not, thoughts?

Does seem reasonable, and since you're already in that neck of the woods...

[nullishamy]

Will implement that, where should it go? Unsure if we'd need to use it in other files and whatnot, so not sure what place would be best.

[mark2185]

All three references to isDirectoryAGitRepository are in app.go, so I guess that is as good place as any.

But Jesse has a better mental model of the entire project so I'd rather hear his two cents clink.

[nullishamy]

Right, I've put it in there for now, will wait for Jesse's opinion on it and alter if needed.

[mark2185]

@jesseduffield should we somehow conflate this isBareRepo and this one?

Currently I think the one from recent_repos_panel isn't reachable from app.go, but maybe it's better to make it public rather than have a duplicate?

[jesseduffield]

Good idea, let's make the existing one public like you say

[nullishamy]

How would that look, and do you want that implemented in this PR? Also how do I go about accessing the existing function?

[mark2185]

How would that look, and do you want that implemented in this PR?

It seems like a trivial change, I see no reason why to postpone it.

Also how do I go about accessing the existing function?

Should be accessible through app.IsBareRepo once you make it public (capitalize it)

[nullishamy]

I'll give it a go.

[mark2185]

I say we wait for Jesse to see if he can deus ex machina this pickle.

I also say we extract it to something like pkg/commands/git_commands/misc.go, throw in IsDirectoryAGitRepository as well and call it a day.

We'll see!

[nullishamy]

I meaaaaaan that's not even a bad idea per-se. But we can wait for Jesse to comment on this one. Go is a real pain sometimes.

[jesseduffield]

the app package can depend on the commands package (which contains git.go) but not vice-versa. I see two approaches we can take here:

1. make it so that we can instantiate the git struct (in git.go) without having to do the validation stuff that currently happens there.
2. Move the code we've got here into pkg/commands/git_commands/status.go Like so:

func (self *StatusCommands) IsBareRepo() (bool, error) {
	return IsBareRepo(self.os)
}

func IsBareRepo(osCommand *oscommands.OSCommand) (bool, error) {
	res, err := osCommand.Cmd.New("git rev-parse --is-bare-repository").DontLog().RunWithOutput()
	if err != nil {
		return false, err
	}

	// The command returns output with a newline, so we need to strip
	return strconv.ParseBool(strings.TrimSpace(res))
}

Then in app.go we call IsBareRepo, passing in our os struct.

I would prefer option 1 but that deserves its own PR, so I'm happy to go with option 2 for now.

[jesseduffield]

the go-git method is very fast btw because it's just checking if a value is nil, but this function is only called when you want to view recent repos so it's not a hot path.

[nullishamy]

That should be that sorted, took me a while to figure out how to import the function lol.

[jesseduffield]

@nullishamy code looks good. You'll need to run gofumpt i.e.

go install mvdan.cc/gofumpt@latest && gofumpt -l -w .

[jesseduffield]

see comment

[nullishamy]

Never saw your comment, I believe that's what you wanted?

[jesseduffield]

nice work @nullishamy !