use better colour defaults #2257
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jesseduffield
force-pushed
the
better-colour-defaults
branch
from
3745933 to
25198c2
Compare
jesseduffield
commented
Nov 10, 2022
| DefaultTextColor = style.FgWhite | ||
|
|
||
| // DefaultHiTextColor is the default highlighted text color | ||
| DefaultHiTextColor = style.FgLightWhite |
Owner
Author
There was a problem hiding this comment.
This wasn't being used
jesseduffield
force-pushed
the
better-colour-defaults
branch
from
25198c2 to
1ac3ae1
Compare
Owner
Author
|
We would need to add a new config value for theme.defaultFgColor. Could you raise an issue for that @simon-abbott ? |
|
I realized this wasn't the best place for that comment so I migrated it to a discussion. I can definitely open a new issue though! |
|
Issue submitted: #2279. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have no way of knowing whether a terminal is in a dark or light theme. HOWEVER we do have one trick up our sleeves: the FgDefault colour is going to be black in a light theme and white in a dark theme. So we need to make use of that colour when rendering text. Previously we allowed the user to configure a 'lightTheme' boolean value that would determine whether to use black or white. We're now removing that config value and just using FgDefault.
fixes #2255
go run scripts/cheatsheet/main.go generate)docs/Config.md) have been updated if necessary