Skip to content

Conversation

@jesseduffield
Copy link
Owner

@jesseduffield jesseduffield commented Dec 28, 2022

  • PR Description

I've captured the creation of the PR in a video in case anybody else wants to do some migrating themselves :) https://www.youtube.com/watch?v=cJtOJu6-HcA&ab_channel=JesseDuffield

  • Please check if the PR fulfills these requirements
  • Cheatsheets are up-to-date (run go run scripts/cheatsheet/main.go generate)
  • Code has been formatted (see here)
  • Tests have been added/updated (see here for the integration test guide)
  • Text is internationalised (see here)
  • Docs (specifically docs/Config.md) have been updated if necessary
  • You've read through your own file changes for silly mistakes etc

@jesseduffield jesseduffield changed the title migrate discard old file change test migrate some more tests Dec 28, 2022
@jesseduffield jesseduffield merged commit ff88230 into master Dec 28, 2022
@jesseduffield jesseduffield deleted the migrate-even-more-tests branch December 28, 2022 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants