Add easter egg #2338
Merged
Add easter egg #2338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jesseduffield
force-pushed
the
snake
branch
4 times, most recently
from
528c034 to
cd824d2
Compare
jesseduffield
commented
Dec 30, 2022
| } | ||
|
|
||
| return (binding.Description != "" || binding.Alternative != "") | ||
| return (binding.Description != "" || binding.Alternative != "") && binding.Key != nil |
Owner
Author
There was a problem hiding this comment.
if a keybinding has no key assigned, we don't want to include it in the cheatsheet
jesseduffield
commented
Dec 30, 2022
| { | ||
| ViewName: "files", | ||
| Description: "stage file", | ||
| Key: 'a', |
Owner
Author
There was a problem hiding this comment.
the existing tests didn't specify a key so they all broke. Because I'm lazy I'm just using key 'a' everywhere to get the passing again
jesseduffield
commented
Dec 30, 2022
|
|
||
| // moves given context's view to the top of the window and returns | ||
| // true if the view was not already on top. | ||
| func (gui *Gui) moveToTopOfWindow(context types.Context) bool { |
Owner
Author
There was a problem hiding this comment.
appeasing the linter because the returned boolean is never used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a fun little easter egg.
I'm precommitting to not improving this easter egg at all; this was just a little holiday stint as a break from integration test migrations.
go run scripts/cheatsheet/main.go generate)docs/Config.md) have been updated if necessary