Add option to disable the "reword in editor" prompt #2384
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No behavior change, just a preparation for the next commit.
jesseduffield
requested changes
Jan 26, 2023
Owner
jesseduffield
left a comment
jesseduffield
left a comment
There was a problem hiding this comment.
Nice work, just one comment :)
docs/Config.md
Outdated
| showIcons: false | ||
| commandLogSize: 8 | ||
| splitDiff: 'auto' # one of 'auto' | 'always' | ||
| skipRewordInEditorPrompt: false # for skipping the confirmation before launching the reword editor |
Owner
There was a problem hiding this comment.
Suggested change
| skipRewordInEditorPrompt: false # for skipping the confirmation before launching the reword editor | |
| skipRewordInEditorWarning: false # for skipping the confirmation before launching the reword editor |
This is more consistent with existing config keys
Collaborator
Author
There was a problem hiding this comment.
OK, makes sense. Here's a fixup: 73316fa.
(A fixup doesn't makes a huge amount of sense for this little PR, also because all the formatting changes, so I'm going to squash it right away.)
Collaborator
Author
There was a problem hiding this comment.
Argh, and the fixup wasn't even complete because I forgot to save Config.md. Sorry for the mess. But the current state should be good now.
stefanhaller
force-pushed
the
disable-reword-in-editor-prompt
branch
from
73316fa to
67fb28e
Compare
Contributor
Uffizzi Preview Environment
|
Owner
|
Nice work @stefanhaller ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new config option
gui.skipRewordInEditorWarning. Addresses #2033.