Skip to content

Conversation

@jesseduffield
Copy link
Owner

@jesseduffield jesseduffield commented Feb 19, 2023

  • PR Description
  • migrates some more integration tests
  • renames PullFiles/PushFiles keybindings to Pull/Push
  • adds a generator file for keeping the integration tests list in-sync.
  • Please check if the PR fulfills these requirements
  • Cheatsheets are up-to-date (run go run scripts/cheatsheet/main.go generate)
  • Code has been formatted (see here)
  • Tests have been added/updated (see here for the integration test guide)
  • Text is internationalised (see here)
  • Docs (specifically docs/Config.md) have been updated if necessary
  • You've read through your own file changes for silly mistakes etc

@github-actions
Copy link
Contributor

github-actions bot commented Feb 19, 2023

Uffizzi Preview Environment deployment-16561

☁️ https://app.uffizzi.com/github.com/jesseduffield/lazygit/pull/2449

📄 View Application Logs etc.

What is Uffizzi? Learn more

@jesseduffield jesseduffield changed the title rename key to Pull more integration test fun Feb 19, 2023
@jesseduffield jesseduffield changed the title more integration test fun add integration test list generator and migrate more tests Feb 19, 2023
@jesseduffield jesseduffield changed the title add integration test list generator and migrate more tests Add integration test list generator and migrate more tests Feb 19, 2023
@jesseduffield jesseduffield merged commit 9da9143 into master Feb 19, 2023
@jesseduffield jesseduffield deleted the migrate-pull-tests branch February 19, 2023 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants