Skip to content

Conversation

@humblepenguinn
Copy link

@humblepenguinn humblepenguinn commented Mar 5, 2023

While running the program in a docker container on a WSL host, there was a bug in the program which falsely identified the runtime as WSL rather than a docker session. A check has been added to see if the current runtime is a docker session or not

  • Please check if the PR fulfills these requirements
  • Cheatsheets are up-to-date (run go run scripts/cheatsheet/main.go generate)
  • Code has been formatted (see here)
  • Tests have been added/updated (see here for the integration test guide)
  • Text is internationalised (see here)
  • Docs (specifically docs/Config.md) have been updated if necessary
  • You've read through your own file changes for silly mistakes etc

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2023

Uffizzi Preview Environment deployment-18181

☁️ https://app.uffizzi.com/github.com/jesseduffield/lazygit/pull/2486

📄 View Application Logs etc.

What is Uffizzi? Learn more

@jesseduffield jesseduffield merged commit 4d78d76 into jesseduffield:master Mar 6, 2023
@jesseduffield
Copy link
Owner

Thanks for making this @humblepenguinn :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants