Skip to content

Conversation

@jenskutilek
Copy link
Contributor

PR Description

The arrow key symbols shown in the UI were inconsistent. For the up/down keys, the characters for

  • U+25B2 BLACK UP-POINTING TRIANGLE
  • U+25BC BLACK DOWN-POINTING TRIANGLE

were used, but the left/right keys used

  • U+25C4 BLACK LEFT-POINTING POINTER
  • U+25BA BLACK RIGHT-POINTING POINTER

Those look different depending on the terminal font:

Bildschirm­foto 2023-03-14 um 10 54 39

This PR uses the matching triangle characters for left/right:

  • U+25C0 BLACK LEFT-POINTING TRIANGLE
  • U+25B6 BLACK RIGHT-POINTING TRIANGLE

Bildschirm­foto 2023-03-14 um 11 07 59

Please check if the PR fulfills these requirements

  • Cheatsheets are up-to-date (run go run scripts/cheatsheet/main.go generate)
  • Code has been formatted (see here)
  • Tests have been added/updated (see here for the integration test guide)
  • Text is internationalised (see here)
  • Docs (specifically docs/Config.md) have been updated if necessary
  • You've read through your own file changes for silly mistakes etc

@github-actions
Copy link
Contributor

github-actions bot commented Mar 18, 2023

Uffizzi Preview Environment deployment-19327

☁️ https://app.uffizzi.com/github.com/jesseduffield/lazygit/pull/2501

📄 View Application Logs etc.

What is Uffizzi? Learn more

@jesseduffield jesseduffield merged commit 5c8bc79 into jesseduffield:master Mar 18, 2023
@jesseduffield
Copy link
Owner

good catch! Merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants