Allow resetting author during rebase #2558
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
This is a small one, and I verified that it doesn't conflict with the big refactor. I didn't add any integration tests for this, let me know if you feel they are necessary. |
Contributor
|
Uffizzi Preview |
Owner
|
Looks good to me. Did you need to do any commit squashing or is this good to merge? |
Collaborator
Author
|
This is good to merge from my side. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow resetting the author of the HEAD commit while in a rebase, and disallow resetting the author for any other commit during a rebase.
We somehow missed that in #2485.
go run scripts/cheatsheet/main.go generate)docs/Config.md) have been updated if necessary