Skip to content

Conversation

@stefanhaller
Copy link
Collaborator

@stefanhaller stefanhaller commented May 2, 2023

People find the new (*) display for branch heads in the commits list confusing, so make it opt-in for now.

  • PR Description

  • Please check if the PR fulfills these requirements

  • Cheatsheets are up-to-date (run go run scripts/cheatsheet/main.go generate)
  • Code has been formatted (see here)
  • Tests have been added/updated (see here for the integration test guide)
  • Text is internationalised (see here)
  • Docs (specifically docs/Config.md) have been updated if necessary
  • You've read through your own file changes for silly mistakes etc

@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2023

Uffizzi Preview deployment-24001 was deleted.

@stefanhaller
Copy link
Collaborator Author

Ah damn, forgot to adapt the integration tests; there is one that explicitly expects the (*). Do we want to duplicate that one and have it with and without the config?

@stefanhaller
Copy link
Collaborator Author

I went ahead and duplicated the test, let me know what you think @jesseduffield.

People find the new (*) display for branch heads in the commits list confusing,
so make it opt-in for now.
@jesseduffield jesseduffield force-pushed the config-for-showing-branch-heads branch from 2f44b54 to fba1a2b Compare May 2, 2023 08:59
@jesseduffield jesseduffield merged commit 4160fa5 into jesseduffield:master May 2, 2023
@jesseduffield
Copy link
Owner

Works for me. I've squashed the commits and merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants