Skip to content

refactor: use slices.Equal to simplify code #4764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stefanhaller merged 1 commit into from
Jul 29, 2025
Merged

refactor: use slices.Equal to simplify code #4764

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pkg/commands/git_commands/main_branches.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package git_commands

import (
"slices"
"strings"
"sync"

Expand Down Expand Up @@ -43,7 +44,7 @@ func (self *MainBranches) Get() []string {

configuredMainBranches := self.c.UserConfig().Git.MainBranches

if self.existingMainBranches == nil || !utils.EqualSlices(self.previousMainBranches, configuredMainBranches) {
if self.existingMainBranches == nil || !slices.Equal(self.previousMainBranches, configuredMainBranches) {
self.existingMainBranches = self.determineMainBranches(configuredMainBranches)
self.previousMainBranches = configuredMainBranches
}
Expand Down
15 changes: 0 additions & 15 deletions pkg/utils/slice.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,18 +179,3 @@ func Shift[T any](slice []T) (T, []T) {
slice = slice[1:]
return value, slice
}

// Compares two slices for equality
func EqualSlices[T comparable](slice1 []T, slice2 []T) bool {
if len(slice1) != len(slice2) {
return false
}

for i := range slice1 {
if slice1[i] != slice2[i] {
return false
}
}

return true
}