Skip to content

Conversation

@kyu08
Copy link
Contributor

@kyu08 kyu08 commented Aug 10, 2025

PR Description

Now, the link of the badge of golangci-lint in README.md is expired. So I fixed it.

PR Description

Now, the link of the badge of golangci-lint in README.md is expired. So I fixed it.

AsIs(Image) image
AsIs(Source code) [![GolangCI](https://golangci.com/badges/github.com/jesseduffield/lazygit.svg)](https://golangci.com)
The change of this PR(Image) image
The change of this PR(Source code) [![golangci-lint](https://img.shields.io/badge/linted%20by-golangci--lint-brightgreen)](https://golangci-lint.run/)

Please check if the PR fulfills these requirements

  • Cheatsheets are up-to-date (run go generate ./...)
  • Code has been formatted (see here)
  • Tests have been added/updated (see here for the integration test guide)
  • Text is internationalised (see here)
  • If a new UserConfig entry was added, make sure it can be hot-reloaded (see here)
  • Docs have been updated if necessary
  • You've read through your own file changes for silly mistakes etc

@stefanhaller stefanhaller added the maintenance For refactorings, CI changes, tests, version bumping, etc label Aug 11, 2025
The old link was broken, it would have to be "Formula/l/lazygit.rb" instead of
"Formula/lazygit.rb".

However, I don't find it very useful to link to the raw formula file, so I
decided to change the link to point to the homebrew web page for lazygit.
It doesn't really seem to make a difference, but this is what I get from
shields.io's builder (no idea where the previous .svg extension came from).
@stefanhaller stefanhaller force-pushed the update-readme-golangci branch from 053df0f to 8a7e42b Compare August 11, 2025 11:41
Both of these badges have the coloring logic to show stable releases in blue,
and prereleases in orange. The criterion for a prerelease is that the major
version is 0. Now it is debatable whether we consider lazygit "stable", but I
don't feel we are in a preliminary state of the project, working towards the
first final 1.0 release, so I feel blue expresses the state of the project
better.
@stefanhaller stefanhaller force-pushed the update-readme-golangci branch from 8a7e42b to 9850137 Compare August 11, 2025 11:42
@stefanhaller
Copy link
Collaborator

Thanks! LGTM.

I added a few more commits to fix the badges for github version and homebrew, if you want to have a look before I merge.

@kyu08
Copy link
Contributor Author

kyu08 commented Aug 11, 2025

@stefanhaller
Thanks for the review and fixes!

I read your all the commit message, and totally agree with your changes and the rationale behind them. 👍

@stefanhaller stefanhaller changed the title Update the badge of golangci-lint in README.md Update the badges of golangci-lint and homebrew in README.md Aug 11, 2025
@stefanhaller stefanhaller merged commit 77a9207 into jesseduffield:master Aug 11, 2025
13 checks passed
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Aug 12, 2025
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [jesseduffield/lazygit](https://github.com/jesseduffield/lazygit) | patch | `v0.54.1` -> `v0.54.2` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>jesseduffield/lazygit (jesseduffield/lazygit)</summary>

### [`v0.54.2`](https://github.com/jesseduffield/lazygit/releases/tag/v0.54.2)

[Compare Source](jesseduffield/lazygit@v0.54.1...v0.54.2)

<!-- Release notes generated using configuration in .github/release.yml at v0.54.2 -->

Here's another point release; this one fixes a performance regression in 0.54.0 that made flicking through diffs a little less snappy (or a lot less, in some scenarios) than it could be.

For the changes in 0.54.0, see https://github.com/jesseduffield/lazygit/releases/tag/v0.54.0.

#### What's Changed

##### Fixes 🔧

- Fix scrollbar in certain popup panels (e.g. the intro message for new users) by [@&#8203;stefanhaller](https://github.com/stefanhaller) in jesseduffield/lazygit#4804
- Fix delay with flicking through files or commits when git diff is very slow by [@&#8203;stefanhaller](https://github.com/stefanhaller) in jesseduffield/lazygit#4803

##### Maintenance ⚙️

- Stop bumping our homebrew formula by [@&#8203;stefanhaller](https://github.com/stefanhaller) in jesseduffield/lazygit#4799
- Update the badges of golangci-lint and homebrew in `README.md` by [@&#8203;kyu08](https://github.com/kyu08) in jesseduffield/lazygit#4807

##### Docs 📖

- Fix the useHunkModeInStagingView hint in the breaking changes message by [@&#8203;stefanhaller](https://github.com/stefanhaller) in jesseduffield/lazygit#4800
- Update `CONTRIBUTING.md` to clarify translation contribution process by [@&#8203;kyu08](https://github.com/kyu08) in jesseduffield/lazygit#4806

**Full Changelog**: jesseduffield/lazygit@v0.54.1...v0.54.2

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS42MS4xIiwidXBkYXRlZEluVmVyIjoiNDEuNjEuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90Il19-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance For refactorings, CI changes, tests, version bumping, etc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants